[Bug 920] Enable client multiplexing to fall back to enhance transparency

[bugzilla-daemon at mindrot.org]

http://bugzilla.mindrot.org/show_bug.cgi?id=920





------- Additional Comments From mouring at eviladmin.org  2004-08-26 12:33 -------
+		/*
+	 	* If we return to here, socket could not be opened.
+	 	* Check for TCP fallback and abort if disabled.
+	 	*/
+
+		if (options.tcp_fallback == 0)
+			fatal("Couldn't connect to %s: %s",
+				options.control_path,
+				strerror(errno));

Not sure I like having the strerror(errno) so far away from the origination point.  Rather
see it inside the control_client();

Either return the error message as part of the char* or  let the function call run 'error()' then fall out of 
the function to let some higher logic decided if other action should be taken.

But I think if one askes to use a pipe and it doesn't exist.  It should whine a bit louder than this patch if 
not create the pipe for future connections to use.

Just something else to consider.

- Ben



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.