[Bug 899] sshd displays illegal usernames through setproctitle()

[bugzilla-daemon at mindrot.org]

http://bugzilla.mindrot.org/show_bug.cgi?id=899





------- Additional Comments From mouring at eviladmin.org  2004-07-21 08:21 -------
I'm ok with the first two.  Makes sense to key off of ->valid since everything 
else does.

I'm leary of the change to do:

setproctitle("%s [pam]", sshpam_authctxt && sshpam_authctxt->valid ? 
pam_user : "unknown");

Mainly because I don't see the  (xx && yy ? zz : pp) abuse normally and as a 
result I'd be skiddy until someone else on the project agrees.

I'd also rather see it as:

if ( ( xx ) && ( yy ) )
 setproc[..]
else 
 setproc[..]

could be I've seen too many (xx & yy) mistakes in OpenBSD audits.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.