[Bug 565] gcc 3.2.3 compiler warnings for openssh-3.6.1p2 on Solaris 7

[bugzilla-daemon at mindrot.org]

http://bugzilla.mindrot.org/show_bug.cgi?id=565





------- Additional Comments From dtucker at zip.com.au  2004-03-30 14:54 -------
(From update of attachment 337)
I re-tested -current (post-3.8p1) on Solaris 2.5.1 w/gcc 3.3.1.

>authfd.c:95: warning: implicit declaration of function `strlcpy'
These are gone.

>authfile.c: In function `key_perm_ok':
>authfile.c:517: warning: unsigned int format, long unsigned int arg (arg 2)
Gone too.

>canohost.c:96: warning: subscript has type `char'
Most of these are still there.

>channels.c:1199: warning: passing arg 4 of `getsockopt' from incompatible pointer type
>channels.c:2072: warning: passing arg 4 of `setsockopt' from incompatible pointer type
SuSv2 defines arg 4 as void *, Solaris 2.5.1 defines it as char *, hence the
warning.

>sshd.c:572: warning: unsigned int format, long unsigned int arg (arg 2)
Gone.

>sshpty.c:412: warning: unsigned int format, mode_t arg (arg 3)
>sshpty.c:415: warning: unsigned int format, mode_t arg (arg 3)
Gone.

>auth.c:434: warning: passing arg 1 of `realpath' discards qualifiers from pointer target type
Still there.

>session.c:2081: warning: implicit declaration of function `gethostname'
Solaris 2.5.1 has gethostname  but no prototype for it.

>monitor.c:1038: warning: int format, pid_t arg (arg 4)
Gone.

>ssh-rand-helper.c:254: warning: implicit declaration of function `getrusage'
No prototype for getrusage.

>ssh-rand-helper.c:535: warning: int format, uid_t arg (arg 3)
>ssh-rand-helper.c:553: warning: int format, uid_t arg (arg 2)
>ssh-rand-helper.c:592: warning: int format, uid_t arg (arg 2)
All gone.

>sftp-server.c:604: warning: implicit declaration of function `utimes'
No prototypes for utimes either.

>sftp-client.c:1046: warning: passing arg 3 of `start_progress_meter' from incompatible pointer type
Still there.

Since most of these are fixed, and most of what's left is due to missing
prototypes, I'm closing this bug.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.