[Bug 983] Required authentication

[bugzilla-daemon at mindrot.org]

http://bugzilla.mindrot.org/show_bug.cgi?id=983





------- Comment #7 from dtucker at zip.com.au  2006-04-17 22:00 -------
(From update of attachment 807)
This bit doesn't seem right:

>+		/* Loop until the required authmethods are done */
>+		if (authenticated && options.required_auth1 != NULL) {
>+			if (auth_remove_from_list(&options.required_auth1, 
>+			    meth_name) != 1)
>+				fatal("INTERNAL ERROR: authenticated method "
>+				    "\"%s\" not in required list \"%s\"", 
>+				    meth_name, options.required_auth1);
>+			debug2("do_authloop: required list now: %s",
>+			    options.required_auth1 == NULL ?
>+			    "DONE" : options.required_auth1);
>+			authenticated = 0;

Unless I'm misreading it, this can't complete.  Once the last method in the
list is successful, "authenticated" is set and options.required_auth1 is
non-null.  The final method is removed and "authenticated" set is zeroed so the
loop goes around again...




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.