[Bug 1221] Banner only suppressed at log level = QUIET (used to be at log level < INFO)

[bugzilla-daemon at mindrot.org]

http://bugzilla.mindrot.org/show_bug.cgi?id=1221

           Summary: Banner only suppressed at log level = QUIET (used to be
                    at log level < INFO)
           Product: Portable OpenSSH
           Version: 4.3p2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P2
         Component: ssh
        AssignedTo: bitbucket at mindrot.org
        ReportedBy: Dean.Kopesky at reuters.com


I don't know whether this counts as a "bug" or a "feature", but I
figured I'd report it....

Prior to version 3.8, the pre-authentication banner (e.g., /etc/issue)
was suppressed at LogLevel=ERROR|FATAL|QUIET.  Since 3.8, it has only
been suppressed at LogLevel=QUIET.  This change was a side-effect of
the following mod:

   - dtucker at cvs.openbsd.org 2003/10/07 01:47:27
     [sshconnect2.c]
     Don't use logit for banner, since it truncates to MSGBUFSIZ;
     bz #668 & #707.  ok markus@

The relevant code is in sshconnect2.c:

input_userauth_banner(int type, u_int32_t seq, void *ctxt)
{
        char *msg, *lang;

        debug3("input_userauth_banner");
        msg = packet_get_string(NULL);
        lang = packet_get_string(NULL);
        if (options.log_level > SYSLOG_LEVEL_QUIET)
                fprintf(stderr, "%s", msg);
        xfree(msg);
        xfree(lang);
}

Was this change in the log level at which the banner prints
intentional?

When ssh is used inside scripts, or forked inside programs, it is (or
rather, was) very nice to be able to suppress the banner, but still get
error messages.  However, we must now choose both or neither.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.