[Bug 1307] client disconnects if ServerAlive enabled but not implemented

[bugzilla-daemon at mindrot.org]

http://bugzilla.mindrot.org/show_bug.cgi?id=1307





------- Comment #4 from djm at mindrot.org  2007-04-19 17:36 -------
The patch looks generally OK, but I'm undecided on whether
SSH2_MSG_IGNORE should tickle the keepalive watchdog. It comes down to
whether the keepalive is a unidirectional "is the other end still
alive?" or end-to-end thing "is the other end still responding to me?".

If it is an end-to-end thing then I think SSH2_MSG_IGNORE should not
restart the keepalive timer as these may be sent by the peer as their
own keepalives, whereas SSH2_MSG_UNIMPLEMENTED will only be sent in
response to something that the local end has send (fulfilling the
end-to-end test requirement).




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.