[Bug 1294] includes.h should pull in string.h based on HAVE_STRING_H

[bugzilla-daemon at mindrot.org]

http://bugzilla.mindrot.org/show_bug.cgi?id=1294

           Summary: includes.h should pull in string.h based on
                    HAVE_STRING_H
           Product: Portable OpenSSH
           Version: 4.6p1
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Build system
        AssignedTo: bitbucket at mindrot.org
        ReportedBy: vapier at gentoo.org


there's some logic in includes.h to handle HAVE_STRINGS_H, but none for
HAVE_STRING_H

the reason for this is that many source files use str* and mem*
functions but are inconsistent as to whether they include string.h ...

for example, these files do not include string.h, yet they use funcs:
entropy.c
scard-opensc.c
ssh-rand-helper.c

in the case of scard-opensc.c, it results in ugly warnings like:
scard-opensc.c: In function 'sc_prkey_op_init':
scard-opensc.c:176: warning: implicit declaration of function 'strcmp'
scard-opensc.c:188: warning: implicit declaration of function 'strlen'
scard-opensc.c:188: warning: incompatible implicit declaration of
built-in function 'strlen'
scard-opensc.c:198: warning: implicit declaration of function 'memset'
scard-opensc.c:198: warning: incompatible implicit declaration of
built-in function 'memset'
scard-opensc.c:204: warning: incompatible implicit declaration of
built-in function 'memset'




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.