[Bug 1390] RekeyLimit max value is too restrictive

bugzilla-daemon at bugzilla.mindrot.org bugzilla-daemon at bugzilla.mindrot.org
Tue Nov 13 09:53:21 EST 2007


https://bugzilla.mindrot.org/show_bug.cgi?id=1390


Jan Pechanec <Jan.Pechanec at Sun.COM> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #1380 is|0                           |1
           obsolete|                            |




--- Comment #1 from Jan Pechanec <Jan.Pechanec at Sun.COM>  2007-11-13 09:53:18 ---
Created an attachment (id=1381)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1381)
fixed patch

I forgot about the initial -1 value... So, the following line was not
correct in the patch then:

if (*activep && options->rekey_limit == -1)

possible solution is to use int64_t for options.rekey_limit and
explicitly cast it to u_int32_t in set_packet_rekey_limit(). Since
rekey_limit is tested against UINT_MAX it's OK.

corrected patch uploaded.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.


More information about the openssh-bugs mailing list