[Bug 1363] sshd gets stuck: select() in packet_read_seqnr waits indefinitely

[bugzilla-daemon at bugzilla.mindrot.org]

http://bugzilla.mindrot.org/show_bug.cgi?id=1363


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #1350 is|0                           |1
           obsolete|                            |
   Attachment #1351|                            |ok?
               Flag|                            |
   Attachment #1350|ok?                         |
               Flag|                            |




--- Comment #7 from Damien Miller <djm at mindrot.org>  2007-09-18 16:53:24 ---
Created an attachment (id=1351)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1351)
Set remain_ms correctly

You are right: that diff only reset the timeout on successful reads,
but not on interrupted select()s.

One concern though: does this impose a timelimit of
(ClientAliveInterval * ClientAliveCountMax) on userauth? 

I'm not sure whether that is desirable, because we already have
LoginGraceTime for that. I'm not sure what the solution is there,
perhaps set the timeout to MAX(LoginGraceTime, ClientAliveInterval *
ClientAliveCountMax), turn the timeout off after KEX, or never turn it
on in the server to begin with?


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.