[Bug 1501] New: p_read, p_send not intialized

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=1501

           Summary: p_read, p_send not intialized
    Classification: Unclassified
           Product: Portable OpenSSH
           Version: 5.0p1
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: ssh
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: THanson at CardinalPeak.com


Source file packet.c declares 2 structures, p_read & p_send, which are
used to manage packet traffic.  These structures are not explicitly
initialized in either the declaration or in the code.

In an environment (i.e. VxWorks) where spawning a second copy (thread)
does not zero-fill memory, this causes the second (and subsequent)
copies to use the values left behind by previous copies.  The result is
that the sequence number (seqnr field) is out of synch with the server
and MAC checksum verification fails.

Recommend setting seqnr, packets, and blocks fields to zero at
process/thread start.  Testing with concurrent threads also
recommended.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.