[Bug 1419] Fix PTY handling on Mac OS X

bugzilla-daemon at bugzilla.mindrot.org bugzilla-daemon at bugzilla.mindrot.org
Tue Jan 8 05:14:38 EST 2008


https://bugzilla.mindrot.org/show_bug.cgi?id=1419





--- Comment #3 from Disco Vince Giffin <vgiffin at apple.com>  2008-01-08 05:14:35 ---
(In reply to comment #2)
> Could you please explain why these are needed?  Does ttyname not work
> on OS X?  And why do you want to not change the ownership of the ptys?

I've spoken with the author of these patches and done some testing.

The first patch (for ttyname) is no longer needed.

The second (permission fix) patch bypasses setowner.  We don't need to
call setowner because the ownership and permissions are already setup
when we allocate a cloning pty.  This patch was added (and is needed)
because when thing close down, and the last file descriptor to the pty
is closed, the kernel removes it from /dev.  So when sshd (thinking the
pty is still there) tries to reset the ownership and permissions, it
gets an error because it isn't there anymore.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.


More information about the openssh-bugs mailing list