[Bug 1486] New: Improperly used buffer during KEX
bugzilla-daemon at bugzilla.mindrot.org
bugzilla-daemon at bugzilla.mindrot.org
Sat Jul 12 21:40:40 EST 2008
https://bugzilla.mindrot.org/show_bug.cgi?id=1486
Summary: Improperly used buffer during KEX
Classification: Unclassified
Product: Portable OpenSSH
Version: 5.0p1
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: Miscellaneous
AssignedTo: unassigned-bugs at mindrot.org
ReportedBy: godji at 300penguins.org
In kex.c:kex_input_kexinit, when a packet with the other side's KEX
proposal is received, it is appended into a buffer that has not been
cleared first. This could lead to problems - in particular, if that
buffer already contains an old peer proposal, the new one will be
appended but the old one will be silently used instead.
The code is currently:
ptr = packet_get_raw(&dlen);
buffer_append(&kex->peer, ptr, dlen);
but should be:
ptr = packet_get_raw(&dlen);
buffer_clear(&kex->peer);
buffer_append(&kex->peer, ptr, dlen);
--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
More information about the openssh-bugs
mailing list