[Bug 1380] incorrect check for strlen(fwd->connect_host) in parse_forward()

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=1380





--- Comment #10 from Jan Pechanec <Jan.Pechanec at Sun.COM>  2009-01-14 04:26:34 ---
(In reply to comment #9)
> Could you refresh my memory as to why NI_MAXHOST is inappropriate?

trying to remember... I'd say it may be the other way around. The point
which I hasn't explained was that on one side the hostname length is
checked against NI_MAXHOST in parse_forward() while on the other side
it's checked against SSH_CHANNEL_PATH_LEN in channel.c's function
channel_setup_fwd_listener().

NI_MAXHOST is usually defined as 1025 (RFC 2553, but obsoleted by 3493
that doesn't even define it). SSH_CHANNEL_PATH_LEN is defined as 255
and used just once.

So, I suggest the same value should be used on both sides.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.