[Bug 1380] incorrect check for strlen(fwd->connect_host) in parse_forward()

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=1380


Tim Rice <tim at multitalents.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tim at multitalents.net




--- Comment #12 from Tim Rice <tim at multitalents.net>  2009-01-14 16:52:43 ---
(In reply to comment #11)
> Created an attachment (id=1591)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1591) [details]
> make c->path dynamic and nuke SSH_CHANNEL_PATH_LEN
> 
> Thanks - that refreshed my memory. This is what I had planned on doing:
> get rid of SSH_CHANNEL_PATH_LEN entirely by making c->path a dynamic
> string.

A quick look at the code turned up
+    u_char *p, dest_addr[255+1], ntop[INET6_ADDRSTRLEN];
We'll need to account for machines that don't have INET6_ADDRSTRLEN

Maybe just adding
#ifndef INET6_ADDRSTRLEN                /* for non IPv6 machines */
#define INET6_ADDRSTRLEN 46
#endif
like we do in sshconnect.c

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.