[Bug 1470] adjust Linux out-of-memory killer to stop sshd being killed

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=1470


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org




--- Comment #1 from Damien Miller <djm at mindrot.org>  2009-01-22 10:38:15 ---
some feedback on the diff:

Isn't /proc/self/oom_adj just an integer? I don't see any bizarre
syntax in the referenced document, but the available docs are seriously
deficient... If it is just an integer then why not just read and write
it using stdio?

I don't think that it should be controlled by an environment variable -
sshd should just set the "never kill me" flag for the master process
unconditionally.

Failure to open() /proc/self/oom_adj shouldn't throw an logit() - this
will just spam older Linux systems that lack the control or don't have
/proc mounted.

The port-linux.c code is incorrect: it doesn't handle EINTR errors on
read()/write() - it should use atomicio() if it can't use stdio.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.