[Bug 1583] User principal name in AIX

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=1583


Simon Wilkinson <simon at sxw.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon at sxw.org.uk




--- Comment #6 from Simon Wilkinson <simon at sxw.org.uk>  2009-07-26 23:22:33 ---
I think the general idea behind this is fine, although I don't have AIX
here to test it on.

However, please use safer string handling functions than strcpy and
strcat. Something like xasprintf() might help - you could replace all
of your current string handling with:

xasprintf(&client, "%s%s%s", 
    (authname?authname:authctxt->pw->pw_name),
    (authdomain?"@":""),
    (authdomain?authdomain:""));

or consider using the buffer routines to build the string.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.