[Bug 1330] RFE: 'ControlPersist' support -- automatically fork and leave ControlMaster behind as a daemon

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=1330

--- Comment #13 from Martin Ling <martin-mindrot-bugzilla at earth.li>  ---
David,

That change to readconf.c doesn't seem to have the desired effect. With
"ControlPersist 0", the master backgrounds forever.

That said, if you tested that behaviour on 5.5p1 then it's probably my
fault - for convenience I'm using your 5.5p1 version of the patch
applied to the source of the current 5.3p1 Ubuntu package - it applied
okay there with one unrelated conflict which I fixed manually.

I'm also wondering if it would be clearer to split the configuration of
this into three options:

ControlTransfer (boolean):

  - False: The ssh invocation which opens the connection will not
terminate until all sessions have closed (as per previous behaviour).

  - True: The ssh invocation which opens the connection will terminate,
but control of the connection will be transferred to another process if
other sessions are using it.

ControlPersist (boolean):

  - False: The connection will be closed when the last session exits.

  - True: The connection will remain open when there are no sessions.

ControlPersistTimeout (time)

  - Zero: The connection will remain open forever (or until lost).

  - Non-zero: The connection will be closed when it has not been used
for the specified time.

With this arrangment, those like me who just want transparent
connection reuse without the complication of the first session becoming
uncloseable, can just set "ControlTransfer yes". Those who want
persistence (arguably a higher risk option) can enable it specifically,
with or without a timeout.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.