[Bug 1967] Potential memory leak in ssh [detected by melton]

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=1967

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au

--- Comment #1 from Darren Tucker <dtucker at zip.com.au> 2011-12-30 20:56:26 EST ---
Thanks.  In general the reports look pretty good.

I think this one is a false positive:
http://lcs.ios.ac.cn/~xuzb/bugsfound/memleak/openssh-5.9p1/realbugs/report-sXUkMC.html#EndPath

  max_fd2 = max_fd;
  client_wait_until_can_do_something(&readset, &writeset,
      &max_fd2, &nalloc, rekeying);

Allocated memory never released. Potential memory leak
Heap object allocated here is not freed

The only way out of that loop is if quit_pending is set, after which
readset and writeset are freed.

I can't figure out what these two are complaining about:
http://lcs.ios.ac.cn/~xuzb/bugsfound/memleak/openssh-5.9p1/realbugs/report-Fs8fvc.html#EndPath
http://lcs.ios.ac.cn/~xuzb/bugsfound/memleak/openssh-5.9p1/realbugs/report-u6oVoX.html#EndPath

I'll attach a patch for the rest shortly.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.