[Bug 1856] New: Wrong QoS naming and obsolete defaults

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=1856

           Summary: Wrong QoS naming and obsolete defaults
           Product: Portable OpenSSH
           Version: 5.8p1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Miscellaneous
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: philipp at redfish-solutions.com


The files defines.h and misc.c refer to the wrong constants.

It should be:

IPTOS_CLASS_CS0

and not:

IPTOS_DSCP_CS0

(etc for 0..7).

These constants are externally defined in /usr/include/netinet/ip.h in
glibc 2.12 and later.

Add:

#define IPTOS_CLASS_DEFAULT IPTOS_CLASS_CS0

Also, the table ipqos[] should probably include:

{ "none", IPTOS_CLASS_DEFAULT },

Lastly, the ToS values defines in RFC-791 were deprecated in 1998 with
the introduction of RFC-2474.  The bit assignments used in RFC-791 now
conflict with other RFCs in deployment such as RFC-3168 (section 5
"Explicit Congestion Notification in IP").

It's strongly recommended that the lines:

        if (options->ip_qos_interactive == -1)
                options->ip_qos_interactive = IPTOS_LOWDELAY;
        if (options->ip_qos_bulk == -1)
                options->ip_qos_bulk = IPTOS_THROUGHPUT;

in servconf.c and readconf.c be replaced by:

        if (options->ip_qos_interactive == -1)
                options->ip_qos_interactive = IPTOS_DSCP_AF21;
        if (options->ip_qos_bulk == -1)
                options->ip_qos_bulk = IPTOS_DSCP_AF11;


as per the definitions in RFC-4594 sections 4.7 ("Low-Latency Data
Service Class") and 4.8 ("High-Throughput Data Service Class"),
respectively... and the documentation of the default values be updated
accordingly.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.