[Bug 1921] New: [Patch] memory leak in sftp-client.c

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=1921

             Bug #: 1921
           Summary: [Patch] memory leak in sftp-client.c
    Classification: Unclassified
           Product: Portable OpenSSH
           Version: -current
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: sftp
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: loganaden at gmail.com


Created attachment 2071
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2071
Fix for memory leak in sftp-client.c

in do_hardlink(), buffer_init(&msg) may be unfreed
if the server does not support hardlink condition is met.

Jonathan Armani (armani@) advises moving it down.

Same thing happens in do_readlink(): if it's unable
to readlink(), the function returns without freeing
msg.

I've attached a patch. This runs on both openbsd -current
& portable openssh -current.

The attached patch concerns portable OpenSSH.

Thanks & Regards,
//Logan
C-x-C-c

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.