[Bug 1273] Interactive mode detection should not be predicated on pty allocation

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=1273

Tim Connors <tim.w.connors at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tim.w.connors at gmail.com

--- Comment #6 from Tim Connors <tim.w.connors at gmail.com> 2011-10-10 11:33:22 EST ---
(In reply to comment #3)
> Sure, the "connection closed" message is arguably redundant in cases
> where the connection was closed because of user interaction, but the
> user may not have been expecting the connection to close.
> 
> For example:
> 
> # ssh -t user at somehost sudo -s
> --- welcome to somehost ---
> # do something
> #
> Connection to somehost closed
> #
> 
> The message is pretty important in this case if the close is
> unexpected, especially if the next command is "reboot" :)

Ideally people have something useful in their $PS1 rather than just
"#".  And if they don't, they deserve to reboot their operational
machines at the wrong time.

> Again, I think Loglevel=quiet is the right answer for you - it
> suppresses only informational messages, warnings and errors are still
> displayed.

Please be aware that the workaround for this bug is not suitable.  For
instance, "ssh -o Loglevel=quiet -t" to a host with a changed hostkeys
results in an error code of 255 and absolutely no messages at all,
instead of the hint:
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@    WARNING: REMOTE HOST IDENTIFICATION HAS CHANGED!     @
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
IT IS POSSIBLE THAT SOMEONE IS DOING SOMETHING NASTY!
...

That in itself is probably a bug, in that the warning message is being
logged at the same level as something as informational as "connection
closed" (seriously?  "connection to blah closed" is logged at a "fatal"
level instead of just "info", according to my testing a moment ago?).

But this would be a lot more acceptable if I didn't have to supply "-o
Loglevel=quiet" just to avoid a silly redundant message printed out at
the end of my non-interactive session that nevertheless needed a tty
allocated.

Please consider reopening this bug.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.