[Bug 1995] New: RequestTTY=no in config doesn't work if stdin is not a tty

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=1995

             Bug #: 1995
           Summary: RequestTTY=no in config doesn't work if stdin is not a
                    tty
    Classification: Unclassified
           Product: Portable OpenSSH
           Version: -current
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: ssh
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: przemoc at gmail.com


Created attachment 2141
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2141
Patch fixing RequestTTY=no that is not taken into account for non-tty
stdin if set in config

I've already reported the problem almost two weeks ago at #openssh, but
apparently developers are available there only virtually (and I agree
it's possibly not the best place for such activity). So this time I'm
writing more proper bug report using bugzilla.

I've noticed that RequestTTY option added in 8bf1740144a4 (May 2011) is
not working 100% as intended (unless used in command-line). I checked
the source code and it's because some tty stuff (touching
options.request_tty) is performed before reading config file.

I think that init log output, read per-user config, fill defaults and
log reinit should be put just after buffer_init(...).
Such fix has been tested and it seems to be working fine, but I may
overlooked some (corner) cases, so please look at my solution in a
cagey manner.

Thanks.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.