[Bug 1964] QoS/DSCP names false translated to ToS hex value

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=1964

--- Comment #4 from martin f. krafft <bugzilla.mindrot.org at pobox.madduck.net> 2012-02-24 18:17:26 EST ---
So it looks as if your #defines do not actually specify the hex value
of the DSCP classes, but they define the hex value shifted left by two
bits. For instance, cs1 is 0x08 in the RFC, but you store 0x20, which
is <<2.

This is all good and well and an implementation detail, really, but I
think the problem is that when someone specifies IPQoS=0x08, they
expect the same behaviour as if they specfied "cs1". However, 0x08 is
used directly without shifting, and so OpenSSH interprets it as 0x02,
which is undefined.

What is the reason that #defines specify shifted values instead of the
standard values, making the shift happen explicitly later?

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.