[Bug 1981] Trying to use ssh with a missing identity file gives no warnings
bugzilla-daemon at mindrot.org
bugzilla-daemon at mindrot.org
Fri Jan 18 10:57:40 EST 2013
https://bugzilla.mindrot.org/show_bug.cgi?id=1981
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #2136| |ok+
Flags| |
--- Comment #4 from Damien Miller <djm at mindrot.org> ---
Comment on attachment 2136
--> https://bugzilla.mindrot.org/attachment.cgi?id=2136
warn for missing user-provided IdentityFiles
ok djm
>--- sshconnect2.c 29 May 2011 11:42:34 -0000 1.180
>+++ sshconnect2.c 9 Mar 2012 00:02:06 -0000
...
>+ if (userprovided)
>+ logit("no such identity: %s: %s", filename,
>+ strerror(errno));
>+ else
>+ debug3("no such identity: %s: %s", filename,
>+ strerror(errno));
I'd probably do this as:
(userprovided ? logit : debug3)("no such identity: %s: %s", filename,
strerror(errno));
but that's just a preference.
>- debug2("key: %s (%p)", id->filename, id->key);
>+ debug2("key: %s (%p), userprovided %d", id->filename, id->key,
>+ id->userprovided);
Maybe %s and (id->userprovided ? " explicit" : "")
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
More information about the openssh-bugs
mailing list