[Bug 2171] New: potential fd leak

[bugzilla-daemon at natsu.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2171

            Bug ID: 2171
           Summary: potential fd leak
           Product: Portable OpenSSH
           Version: -current
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: sftp
          Assignee: unassigned-bugs at mindrot.org
          Reporter: loganaden at gmail.com

in sftp-client.c:

        if (resume_flag) {
                if (fstat(local_fd, &st) == -1) {
                        error("Unable to stat local file \"%s\": %s",
                            local_path, strerror(errno));
                        goto fail;
                }
                if ((size_t)st.st_size > size) {
                        error("Unable to resume download of \"%s\": "   
                            "local file is larger than remote",
local_path);    
 fail:
                        do_close(conn, handle, handle_len);
                        buffer_free(&msg);
                        free(handle);
                        return -1;

in the fail label, local_fd is not closed in case open() call was
successful.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.