[Bug 2252] RekeyLimit breaks ClientAlive

[bugzilla-daemon at mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2252

Garrett Lee <glee at ciena.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |glee at ciena.com

--- Comment #1 from Garrett Lee <glee at ciena.com> ---
I am also experiencing this problem and investigating an appropriate
fix.  Thank you for point out a possible fix, it saved me the time of
having to dig around through the code. 

Looking at your proposed fix, I am wondering about the case where
max_time_milliseconds actually is value 0.  I think if the rekey-time
is 0 then with your proposed code change it will skip the
tcp-keepalive.

Do you suppose the following code change would cover cases when rekey
time is zero and cases where it is non-zero?

    if (compat20 &&
            options.client_alive_interval &&
        ((max_time_milliseconds == 0) || (max_time_milliseconds >
((u_int64_t)options.client_alive_interval * 1000))) ) {
...

-- 
You are receiving this mail because:
You are watching the assignee of the bug.