[Bug 2345] New: NESTING_INDENT_MISMATCH: missing parenthesis around if body in ssh-keygen.c:724

[bugzilla-daemon at mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2345

            Bug ID: 2345
           Summary: NESTING_INDENT_MISMATCH: missing parenthesis around if
                    body in ssh-keygen.c:724
           Product: Portable OpenSSH
           Version: 6.7p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: ssh-keygen
          Assignee: unassigned-bugs at mindrot.org
          Reporter: jjelen at redhat.com

Created attachment 2538
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2538&action=edit
patch

Our coverity scan on openssh found one defect - body of function in
above mentioned line is not in parenthesis so it doesn't do what it is
supposed to do or if it does, it is pretty confusing by the
indentation.

It probably does what it is supposed to do, because sshkey_write
probably fails with private key, but I wouldn't rely on it.

This problem is there quite long, since
44b25040110a224a79ff371ee548be9a10ba8bfa, Fri Jul 2 13:35:01 2010

For patch (demonstration) see attachment.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.