[Bug 2416] [PATCH] Allow forwarding of stdio to streamlocal end points

[bugzilla-daemon at mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2416

--- Comment #2 from Darren Tucker <dtucker at zip.com.au> ---
Comment on attachment 2654
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2654
the patch

>-channel_connect_stdio_fwd(const char *host_to_connect, u_short port_to_connect,
>+channel_connect_stdio_fwd(const char *path_to_connect, u_int port_to_connect,

any reason to keep port_to_connect as unsigned?  PORT_STREAMLOCAL is
negative and a signed int can cover that as well as the entire port
range without casts.

Also, I think I'd rather not rename host_to_connect: path_to_connect
isn't correct for the common case either and it makes the change a long
more invasive.

Still looking at rest of patch.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.