[Bug 2465] openssh portable does not check if arc4random_buf is declared in the system headers?

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2465

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
I was wondering why this was causing problems at all - normally we
wouldn't pick up these symbols from libcrypto because most library
tests are done only against libc. So I checked this history to see why
these were done late:

> commit 00f9cd230709c04399ef5ff80492d70a55230694
> Author: Damien Miller <djm at mindrot.org>
> Date:   Tue Jul 15 10:41:38 2014 +1000
> 
> - (djm) [configure.ac] Delay checks for arc4random* until after libcrypto
>   has been located; fixes builds agains libressl-portable

So this used to work. What changed?

IMO if you're going to provide replacements for functions usually in
libc, then you should provide prototypes for them too. You can't expect
programs to pick up your symbols but provide their own prototypes -
what if your prototype doesn't match ours?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.