[Bug 2463] Conflict with openbsd compat glob() function in shared libraries

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2463

Jakub Jelen <jjelen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2704|0                           |1
        is obsolete|                            |

--- Comment #3 from Jakub Jelen <jjelen at redhat.com> ---
Created attachment 2707
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2707&action=edit
patch reworked as proposed

Thank you for comments. I knew there will be better and more
maintainable way to do so. I reworked the patch as advised and it works
well. I hope I got it right :)

Keeping the GLOB_* constants in whole openbsd-compat.h would make
problems since it is included everywhere and they have totally
different numerical values (for example) on linux than on openbsd.

As a resolution I moved glob include to sftp-client.h, which is only
place where we need compat_glob. The other places requiring glob should
include system glob on their own.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.