[Bug 2604] New: Remove orphaned do_pam_set_tty() or make use of it

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2604

            Bug ID: 2604
           Summary: Remove orphaned do_pam_set_tty() or make use of it
           Product: Portable OpenSSH
           Version: 7.3p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: PAM support
          Assignee: unassigned-bugs at mindrot.org
          Reporter: jjelen at redhat.com

today I ran into problems with PAM and bumped into the function
do_pam_set_tty(), which is defined, but never used, if I see right:

$ git grep do_pam_set_tty
auth-pam.c:do_pam_set_tty(const char *tty)
auth-pam.h:void do_pam_set_tty(const char *);

There is basically duplicate code in sshpam_init(). In the git, last
usage of this function was removed in 2008 [1]. I don't think it makes
sense to keep it.


[1] https://github.com/openssh/openssh-portable/commit/52358d6d

-- 
You are receiving this mail because:
You are watching the assignee of the bug.