[Bug 2617] sign_and_send_pubkey: no separate private key for certificate

bugzilla-daemon at bugzilla.mindrot.org bugzilla-daemon at bugzilla.mindrot.org
Tue Dec 6 23:29:03 AEDT 2016


https://bugzilla.mindrot.org/show_bug.cgi?id=2617

--- Comment #8 from Adam Eijdenberg <adam at continusec.com> ---
Hi Damien,

I've tested your patch against the same tests I included in my original
PR (https://github.com/openssh/openssh-portable/pull/53) however I'm
seeing the same segfaults that I encountered when I tried to make mine.
:)

The problem (I think) is that identity_sign() calls
identity_sign_encode() before doing anything, and
identity_sign_encode() attempts to dereference id->key->type which is
problematic since id->key is NULL.

I'll attach a patch that addresses the segfaults, and separately a
patch with the tests that I'd put in the original PR (even though this
patch doesn't address all of them).

Cheers, Adam

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.


More information about the openssh-bugs mailing list