[Bug 2559] Warnings from reading moduli file, refer to primes file

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2559

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2543
           Assignee|unassigned-bugs at mindrot.org |dtucker at zip.com.au
                 CC|                            |dtucker at zip.com.au
             Status|NEW                         |ASSIGNED

--- Comment #1 from Darren Tucker <dtucker at zip.com.au> ---
diff looks ok, however the "primes" file was deprecated in 2001:

$ cvs log dh.c
[...]
revision 1.15
date: 2001/06/22 21:27:07;  author: provos;  state: Exp;  lines: +4 -4;
use /etc/moduli instead of /etc/primes, okay markus@

so I suspect we'd be better off just removing the fallback.  If you
haven't updated in 15 years then logging a warning and falling back to
the built-in groups is the least of your problems.

While there:
 logit("WARNING: %s does not exist, using fixed modulus", moduli_path);

While being missing is the most likely reason the open failed, it's not
the only one.  While we're making it more accurate we should include
the real reason too.


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2543
[Bug 2543] Tracking bug for OpenSSH 7.3 release
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.