[Bug 2564] ssh_config AddKeysToAgent doesn't set key name/path

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2564

Vincent Brillault <git at lerya.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |git at lerya.net

--- Comment #3 from Vincent Brillault <git at lerya.net> ---
Created attachment 2894
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2894&action=edit
AddKeysToAgent: Use filename when comment is empty

I took a look at this bug by chance and I think I found the 'issue':
ssh-add has a check verifying if the 'comment' of the key is NULL or
contains only '\0' and replace it with the filename in that case (see
https://github.com/openssh/openssh-portable/blob/master/ssh-add.c#L261-L262,
seems to have been added in
https://github.com/openssh/openssh-portable/commit/2681cdb6e0de7c1af549dac37a9531af202b4434)

The attached patch simply duplicate that behaviour (looking at
sshkey_parse_private_fileblob_type, RSA key always have a 'NULL'
comment).
It seems to fix the issue for me, can you confirm?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.