[Bug 2625] Support Capabilities for ssh client port forwarding

bugzilla-daemon at bugzilla.mindrot.org bugzilla-daemon at bugzilla.mindrot.org
Mon Oct 24 17:10:15 AEDT 2016


https://bugzilla.mindrot.org/show_bug.cgi?id=2625

--- Comment #5 from Darren Tucker <dtucker at zip.com.au> ---
(In reply to Alexey Mochkin from comment #4)
> Your bind_permitted() function should have fallback to check for uid
> == 0 if no capabilities were presented.

fair enough, but it'd be cleaner if it just fell through, eg:

int
bind_permitted(int port, uid_t uid)
{
#ifdef LINUX_CAPABILITIES
        if (linux_capability_bind_permitted())
                return 1;
#endif
        if (port < IPPORT_RESERVED && uid != 0)
                return 0;
        return 1;

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.


More information about the openssh-bugs mailing list