[Bug 2767] Missing includes in bsd-err.c

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2767

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Blocks|                            |2698
                 CC|                            |dtucker at zip.com.au
             Status|NEW                         |RESOLVED

--- Comment #1 from Darren Tucker <dtucker at zip.com.au> ---
(In reply to Colin Watson from comment #0)
> Created attachment 3040 [details]
> Add missing includes to openbsd-compat/bsd-err.c

Applied, thanks.

> I went through and added all the missing #includes in the attached
> patch.  Some duplicate "includes.h", but it seems to be reasonably
> common practice in OpenSSH to add direct #includes for symbols that
> are used directly.

Current policy is to include system headers in the .c file where
they're needed however some of the compat code either needs it earlier,
was added prior to the policy or both.


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2698
[Bug 2698] Tracking bug for OpenSSH 7.6 release
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.