[Bug 2804] channels.c:3258: suspicious code ?

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2804

--- Comment #2 from David Binderman <dcb314 at hotmail.com> ---
(In reply to Damien Miller from comment #1)
> AFAIK this is actually correct

Righto.

> (yes, this is confusing)

So it could do with simplifying.

The code I mentioned does this kind of thing:

  else if (x != A 
    || x == B
    || x == C)

That can be simplified downto

  else if (x != A)

with no loss of functionality.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.