[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2434

--- Comment #13 from Damien Miller <djm at mindrot.org> ---
oops, yes. What happens if a window size change happens between
update_progress_displayname() and update_progress_meter()?

It looks like it will cause the filename to only be updated after both
have been called. If this is the case, could you move setscreensize()
out of update_progress_meter() (where it is in signal context and
strictly not safe) and into update_progress_displayname().

Also:

> +			strnvis(buf, file, sizeof buf, VIS_SAFE);

I think smprintf() will fallback to vis(3) internally so you shouldn't
need this case.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.