[Bug 2658] New: Make integrity tests more robust against timeouts

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2658

            Bug ID: 2658
           Summary: Make integrity tests more robust against timeouts
           Product: Portable OpenSSH
           Version: 7.4p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Regression tests
          Assignee: unassigned-bugs at mindrot.org
          Reporter: cjwatson at debian.org

Created attachment 2924
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2924&action=edit
Make integrity tests more robust against timeouts

If the first test in a series for a given MAC happens to modify the low
bytes of a packet length, then ssh will time out and this will be
interpreted as a test failure.  I'm seeing this in practice on Ubuntu
ppc64el (e.g.
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-zesty/zesty/ppc64el/o/openssh/20161231_121729_ebc8a@/log.gz).

Fortunately there was already an XXX comment indicating what might be
going wrong here, and although I haven't been able to reproduce it
directly on a system where I can experiment interactively, I can at
least reproduce it by fiddling with the start offset, which was enough
to be able to put together a patch to make the tests more robust.  That
patch is attached.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.