[Bug 2664] New: Boolean option parsing is excessively case-sensitive

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2664

            Bug ID: 2664
           Summary: Boolean option parsing is excessively case-sensitive
           Product: Portable OpenSSH
           Version: 7.4p1
          Hardware: Other
               URL: https://bugs.launchpad.net/bugs/1656557
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: sshd
          Assignee: unassigned-bugs at mindrot.org
          Reporter: cjwatson at debian.org

The pure yes/no options in sshd that are handled by parse_flag are
case-sensitive.  For example, "PasswordAuthentication yes" is accepted
while "PasswordAuthentication Yes" is not.  This seems unnecessarily
picky, since the meaning is unambiguous and it's an easy mistake for
users to make.  It's also at variance with (1) all the options handled
by parse_multistate in servconf.c and (2) the corresponding code in
readconf.c to handle client options, both of which use strcasecmp.

I'd suggest that it would make sense to make the handling in servconf.c
work the same way as that in readconf.c, where parse_flag just sets
multistate_ptr = multistate_flag and falls through to parse_multistate;
the code would even be shorter as a result.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.