[Bug 2748] New: Bug compatibility masks incorrectly match WinSCP 5.10.x

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2748

            Bug ID: 2748
           Summary: Bug compatibility masks incorrectly match WinSCP
                    5.10.x
           Product: Portable OpenSSH
           Version: 7.5p1
          Hardware: Other
                OS: Other
            Status: NEW
          Severity: normal
          Priority: P5
         Component: sshd
          Assignee: unassigned-bugs at mindrot.org
          Reporter: martin at winscp.net

The compat_datafellows function in compat.c includes this rule:

                { "WinSCP_release_4*,"
                  "WinSCP_release_5.0*,"
                  "WinSCP_release_5.1*,"
                  "WinSCP_release_5.5*,"
                  "WinSCP_release_5.6*,"
                  "WinSCP_release_5.7,"
                  "WinSCP_release_5.7.1,"
                  "WinSCP_release_5.7.2,"
                  "WinSCP_release_5.7.3,"
                  "WinSCP_release_5.7.4",
                                        SSH_OLD_DHGEX },

Unfortunately the "WinSCP_release_5.1*" mask inadvertently matches even
the latest branch of WinSCP 5.10 with version string like
"WinSCP_release_5.10.4".

Can you please change the masks to require a dot?

                { "WinSCP_release_4*,"
                  "WinSCP_release_5.0,"
                  "WinSCP_release_5.0.*,"
                  "WinSCP_release_5.1,"
                  "WinSCP_release_5.1.*,"
                  "WinSCP_release_5.5,"
                  "WinSCP_release_5.5.*,"
                  "WinSCP_release_5.6,"
                  "WinSCP_release_5.6.*,"
                  "WinSCP_release_5.7,"
                  "WinSCP_release_5.7.1,"
                  "WinSCP_release_5.7.2,"
                  "WinSCP_release_5.7.3,"
                  "WinSCP_release_5.7.4",
                                        SSH_OLD_DHGEX },

Thanks.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.