[Bug 2763] Broken parsing of link-local addresses when interface contains upper-case letter

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2763

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3068|0                           |1
        is obsolete|                            |
   Attachment #3086|                            |ok?
              Flags|                            |

--- Comment #8 from Damien Miller <djm at mindrot.org> ---
Created attachment 3086
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3086&action=edit
don't lowercase but explicitly canonicalise address

I just realised that the previous patch will cause problems for people
who have learned hostkeys for IPv6 addresses and then subsequently
attempt to connect to them but using upper-case addresses, e.g.

ssh FE80::1%lo0

This skips the lowercasing for addresses but still sends them through a
getaddrinfo()/getnameinfo() wash to render them in canonical form. This
should preserve uppercase interface scopes (modulo bugs in libc).

It also aborts hostname canonicalisation for address-like strings that
don't parse as addresses, such as addresses with unrecognised interface
scoping.

BTW, Darren - someone replaced all the bzero() calls with memset() in
OpenSSH a while back. I complained at the time, but I don't want to be
the guy who adds the first one back in :/

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.