[Bug 2474] Enabling ECDSA in PKCS#11 support for ssh-agent

bugzilla-daemon at bugzilla.mindrot.org bugzilla-daemon at bugzilla.mindrot.org
Thu Nov 30 21:50:33 AEDT 2017


https://bugzilla.mindrot.org/show_bug.cgi?id=2474

--- Comment #17 from Mathias <mathias at brossard.org> ---
Thanks for catching that, Dmitry.  I don't know how I ended up with the
sixth iteration patch, but I intended to improve to the following
(moving the memcpy inside the if):

+       /* identify key object on smartcard */
+       k11->keyid_len = keyid_attrib->ulValueLen;
+       if (k11->keyid_len > 0) {
+               k11->keyid = xmalloc(k11->keyid_len);
+               memcpy(k11->keyid, keyid_attrib->pValue,
k11->keyid_len);
+    }

-- 
You are receiving this mail because:
You are watching the assignee of the bug.


More information about the openssh-bugs mailing list