[Bug 2790] New: parameter ssh of function ssh channel_clear_permitted_opens could be NULL

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2790

            Bug ID: 2790
           Summary: parameter ssh of function ssh
                    channel_clear_permitted_opens could be NULL
           Product: Portable OpenSSH
           Version: 7.6p1
          Hardware: Other
                OS: Other
            Status: NEW
          Severity: critical
          Priority: P5
         Component: Miscellaneous
          Assignee: unassigned-bugs at mindrot.org
          Reporter: yawang at microsoft.com

key base auth fail on windows because parameter ssh ssh-agent on
windows is null and the demon crashes. ssh-agent does not call
auth_clear_options but it does not need to call packet_set_connection. 


void
channel_clear_permitted_opens(struct ssh *ssh)
{
        struct ssh_channels *sc = ssh->chanctxt;

        sc->permitted_opens = xrecallocarray(sc->permitted_opens,
            sc->num_permitted_opens, 0, sizeof(*sc->permitted_opens));
        sc->num_permitted_opens = 0;
}

Please add parameter check.

        if(ssh == NULL)
                return;

-- 
You are receiving this mail because:
You are watching the assignee of the bug.