[Bug 2773] Potential segfault from ssh_remote_ipaddr()

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2773

--- Comment #2 from Jakub Jelen <jjelen at redhat.com> ---
Yes, it is a patched audit code, but I don't see a reason why the
packet layer could not return the cached values even after the
connection is cleaned up (this was one of the use cases why this data
is cached in the first place).

If it is a design decision, that it should not work, the code should
certainly not dereference NULL pointers before checking it and should
not segfault instead of gracefully failing (or falling back to UNKNOWN)
in this case, even though you are sure it can not be called from your
code without valid state.

We probably need the IP address for auditing reasons and I don't see a
simple way to call that earlier.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.