[Bug 2948] implement "copy-data" sftp extension

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2948

--- Comment #3 from Darren Tucker <dtucker at dtucker.net> ---
Comment on attachment 3344
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3344
sftp copy-data extension

> [...] This avoids needing to
>+download the data before uploading it across the network twice.

Why uploading twice?

[...]
>+	{ "copy-data", "copy-data", 0, process_extended_copy_data, 1 },

This is a protocol violation.  The server is implementing
secsh-filexfer-02 which does not specify copy-data.  Vendor extensions
such as this need an @[domainname] suffix.

[...]
>+				ret = read(read_fd, buf, len);

ret should be ssize_t not int.

That said I don't think we'd consider this without a client
implementation since without that we can't test it.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.