[Bug 2335] Config parser accepts ip/port in ListenAddress and PermitOpen

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2335

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3231|ok?(djm at mindrot.org)        |ok+
              Flags|                            |

--- Comment #7 from Damien Miller <djm at mindrot.org> ---
Comment on attachment 3231
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3231
remove support for obsolete host/port notation

ok, but two nits:


>+char	*hpdelim2(char **, char *);

Maybe hpdelim_char() would be a little more descriptive?

>--- servconf.c	19 Jan 2019 21:37:48 -0000	1.346
>+++ servconf.c	23 Jan 2019 10:44:04 -0000
...
>@@ -1251,8 +1251,10 @@ process_server_config_line(ServerOptions
> 			port = 0;
> 			p = arg;
> 		} else {
>-			p = hpdelim(&arg);
>-			if (p == NULL)
>+			char ch;
>+			arg2 = NULL;

Either newline after "char ch" or move it to the declarations of the
start of the function

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.