[Bug 3032] (Fixable) MIPSPro compilation errors, failing regression test in test_sshbuf_misc.c & sshd host key loading issues on IRIX 6.5

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=3032

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at dtucker.net

--- Comment #1 from Darren Tucker <dtucker at dtucker.net> ---
>   cc-1515 c99: ERROR File = sshkey.c, Line = 1270
>     A value of type "int" cannot be assigned to an entity of type
> "char *".
> 
>           if ((blobcopy = strndup(cp, space)) == NULL) {
> 
> This one I managed to 'fix' by casting the strndup() return value to
> (char*). I naively assume that is a valid solution? 

It's not a proper fix.  It'll probably work in some case where ints and
pointers are the same size, but in others (eg "LP64" systems where only
longs and pointers are 64 bit) it'll truncate the pointer.

This one is probably because it doesn't have the prototype for strndup.
 In C (well, up to c89 at least) functions are assumed to return int.

Is it using the system's (ie does config.h define HAVE_STRNDUP)?  If
not we need to add the prototype to the compat library headers.    You
want to add the prototype "char *strndup(const char *s, size_t n);"

> The second error is only triggered when the --with-prngd-socket=
> configure option is set:
> 
>   cc-1126 c99: ERROR File = entropy.c, Line = 213
>     Expected a statement.

Thanks, I've applied the fix for that:
https://github.com/openssh/openssh-portable/commit/01a1e21cd55d99293c8ff8ed7c590f2ee440da43

> After successfully building OpenSSH with these two 'fixes', make
> tests fails as follows:

I'd try again after fixing the strndup thing.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.