[Bug 2848] Adding an option to control Nagle's algorithm (enable/disable) can lead to significant speedups

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2848

--- Comment #4 from Thanassis Tsiodras <ttsiodras at gmail.com> ---
@Damien Miller: What I am saying (please see the linked post in UNIX
Stack Exchange for details) is that when used as a transport, SSH
cannot predict what is best; in my case, stracing showed that
TCP_NODELAY was enabled, greatly impacting the speed over my congested
WiFi link. 

    # from strace output - for details see the linked StackExchange
post
    1522665534.007899 setsockopt(3, SOL_TCP, TCP_NODELAY, [1], 4) = 0
<0.000021>

A simple addition of two options that control the setting...

    --nodelay (default)
    --delay 

...would allow tools like borgbackup and rsync (that use SSH as a
transport) to try out and adapt to whatever works best. Note that in
the link from Kristian posted above, you can see arguments from the
other side of the Nagle spectrum - basically confirming that direct
control of Nagle's setup is a desired trait! 

And an easy one to add, I believe... (it's just a global boolean flag).

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.