[Bug 3129] Add IP address to error kex_exchange_identification error message

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=3129

--- Comment #2 from Ulrich Windl <Ulrich.Windl at rz.uni-regensburg.de> ---
(In reply to Darren Tucker from comment #1)

The patch looks OK for me, but I cannot really test it as the machine
where I see it is some appliance where I can't replace code, and I'm
not able to trigger this error on any machines where I could replace
sshd.
The only thing in the patch that makes me (as a no-"ssh developer")
wonder is the size reserved for the identification: 512
It should be large enough, but maybe even it's too large. Isn't there a
symbolic constant for that?

Other things I'm thinking of is the consistency of messages containing
the peer:
"from server %s" (at end)
"with peer %s" (at end)
"remote host %s" (at end)
"%s: peer %s" (at beginning)
"from peer %s" (in middle)
"with peer %s" (in middle)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.